(A013) [ModelicaSystemDoE] simplify definition#423
Open
syntron wants to merge 5 commits intoOpenModelica:masterfrom
Open
(A013) [ModelicaSystemDoE] simplify definition#423syntron wants to merge 5 commits intoOpenModelica:masterfrom
syntron wants to merge 5 commits intoOpenModelica:masterfrom
Conversation
syntron
force-pushed
the
ModelicaSystemDoE
branch
3 times, most recently
from
10db374 to
3c62d45
Compare
[ModelicaSystemDoE] simplify definition; use a Modelicasystem instance as argument [ModelicaSystemDoE] update docstring [ModelicaSystemDoE] fix for relative paths [ModelicaSystemDoE] fix unittest * test_ModelicaSystemDoE_local is tested * test_ModelicaSystemDoE_docker should work * test_ModelicaSystemDoE_WSL is untested
syntron
force-pushed
the
ModelicaSystemDoE
branch
from
3c62d45 to
7e8b418
Compare
adeas31
reviewed
Mar 2, 2026
| tmpdir = tmp_path / 'DoE' | ||
| tmpdir.mkdir(exist_ok=True) | ||
| omcs = OMPython.OMCSessionWSL() | ||
| assert omcs.sendExpression("getVersion()") == "OpenModelica 1.25.0" |
Member
There was a problem hiding this comment.
I know this will not run on GitHub tests but still what is the point of checking against hard coded version?
Contributor
Author
There was a problem hiding this comment.
The idea is to ensure within the test definition directly after the setup that OMC is running; the check could be removed ...
Member
There was a problem hiding this comment.
Rather than validating against a specific version, we can check whether getVersion() returns a non-empty result to ensure that OMC is functioning correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see PR #404